Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework round and trunc #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jverzani
Copy link
Collaborator

This introduces these semantics for round and trunc

  • both pass on non real values
  • trunc and round return Sym objects (this is a change)
  • round only uses the digits argument.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #473 (6dbebb0) into master (29c5bfd) will increase coverage by 0.58%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   55.81%   56.39%   +0.58%     
==========================================
  Files          19       19              
  Lines        1179     1188       +9     
==========================================
+ Hits          658      670      +12     
+ Misses        521      518       -3     
Impacted Files Coverage Δ
src/generic.jl 54.79% <80.00%> (+11.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c5bfd...6dbebb0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants