-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fixes #4974
CI fixes #4974
Conversation
Behaviour was changed such that ã becomes \tilde{a}, instead of \textnormal{\~{a}}.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4974 +/- ##
==========================================
- Coverage 89.77% 89.75% -0.02%
==========================================
Files 40 40
Lines 8780 8817 +37
==========================================
+ Hits 7882 7914 +32
- Misses 898 903 +5 ☔ View full report in Codecov by Sentry. |
The ubuntu/macOS + Julia 1.6 tests are failing because of image comparison regression tests, specifically on image number 6 with GR backend. Looking across a bunch of logs, it seems that any runs with GR.jl v0.73.x cause this test to fail, whereas v0.72.x works. I've extracted the images from the GitHub runner, for good measure: ubuntu-latest, 1.6
macOS-13, 1.6
Reference imageTaken from https://github.com/JuliaPlots/PlotReferenceImages.jl/blob/master/Plots/gr/1.36.4/ref006.png |
@BeastyBlacksmith, pinging you because you sorted my other PR, I hope that is ok:) I think this might be the extent to which I feel confident in fixing stuff. The version clash on GR (comment above, Column 2 below) is a bit bizarre; I've tried to track down why it resolves to 0.72.8 sometimes and 0.73.7 other times, but without any success. If we stick a The Windows + Julia 1.6 tests currently time out because of Kaleido. It could be made to run by bumping the compat on PlotlyKaleido to (If we update compat for both deps (Column 5), and also update the image regression test, then I think all the tests should pass.)
|
Thank you for taking a look into this. On GR: given that the reference clearly has artifacts that got fixed it seems reasonable to me to set the compat to 0.73 and update the refrence image. On PlotlyKaleido: This ones a bit more work. Since, to be compatible with PlotlyKaleido v2 we need to check in the |
@penelopeysm would you be willing to do a v2 port of this? |
Happy to do that! 🙂 |
* CI fixes (#4974) * Update tests for Latexify 0.16.5 Behaviour was changed such that ã becomes \tilde{a}, instead of \textnormal{\~{a}}. * Test Julia 1.6 on x86 macOS instead of ARM See: https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019 * Bump GR compat and Plots version number * update plotly show methods for PlotlyKaleido v2 * remove Pkg * add it back --------- Co-authored-by: Simon Christ <[email protected]> * Don't need to edit CI for 1.6 as no longer supported * Don't test GR/50 on macOS * Reorganise failing tests - Disabled reference tests 25 and 30, which require StatsPlots support, for all backends (in PlotsBase/src/examples.jl) - Separate tests that are skipped and tests that are known to be broken due to upstream issues - Re-enable reference test 41 as upstream issue has been fixed (JuliaLang/julia#47261) - Disable reference test 50 because of upstream issue (jheinen/GR.jl#550) --------- Co-authored-by: Simon Christ <[email protected]>
Description
Attribution
Things to consider