Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecipesPipeline: GroupBy: apply idxfilter to errorbars #4967

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

lukas-weber
Copy link
Contributor

Fixes #4917

Description

I included :xerror, :yerror, and :zerror in the list of keys that idxfilter gets applied to. Maybe there are other keys that should be included?

Also not sure if there is a smarter way to test it.
idxfilter does not seem to be documented, so I did not edit documentation for now.

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (5a611ce) to head (894d8eb).
Report is 2 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #4967   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files          51       51           
  Lines        6003     6003           
=======================================
  Hits         5229     5229           
  Misses        774      774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukas-weber
Copy link
Contributor Author

Just making sure- is this PR blocked on anything in particular that I could help with?
In case documentation is required, I’m happy to add it, just did not want to accidentally document a non-public API.

Thanks everyone for their work on Plots.jl! 😃

@BeastyBlacksmith
Copy link
Member

It's fine as is, thanks for bumping. Documenting non-public API is fine as long as it does not show up here

@BeastyBlacksmith BeastyBlacksmith merged commit 17b6ca0 into JuliaPlots:v2 Oct 2, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] grouping Measurement data leads to wrong errorbars in plot
2 participants