GR: draw gridlines below all axes #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separates grid drawing from the remainder of gr_draw_axis, so that all gridlines are drawn below the axis. Previously, y-axis gridlines were drawn after the x-axis and could overlap it. Fixes issue JuliaPlots#4202 for GR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4945 +/- ##
==========================================
- Coverage 89.77% 89.70% -0.07%
==========================================
Files 40 40
Lines 8780 8814 +34
==========================================
+ Hits 7882 7907 +25
- Misses 898 907 +9 ☔ View full report in Codecov by Sentry. |
Yes, that is correct |
|
I set that up for you in JuliaPlots/PlotReferenceImages.jl#151 |
7 tasks
|
Sorry about taking so long to respond -- I now made a second PR with essentially the same changes for v2. |
|
Thanks! Consider adding your name to our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GR currently plots all components of the x-axis first, and then the y-axis (and possibly z). Since horizontal gridlines belong to the y-axis, if there's a tick at the low end of
xrange, the corresponding gridline will cover the x-axis (see issue #4202).This fixes the issue for GR by splitting
gr_draw_axisinto three stages, so that we first draw all minor gridlines, then all major gridlines, and the rest of the axis on top.With the change, a few image tests would need to be updated, in which the x-axis colour is now no longer affected by the (transparent) overlapping gridline -- as far as I can see, no visible changes. I assume that this is done separately in https://github.com/JuliaPlots/PlotReferenceImages.jl/?
Attribution
Things to consider