Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloads count badge #4922

Merged

Conversation

pricklypointer
Copy link
Contributor

Fixed the download count badge using https://juliapkgstats.com/. The current badge is broken because the old API and PkgVisBoard is not maintained.

This PR:

  • Replaces the broken badge with a new badge that uses the new API

Please review and provide any feedback. Thanks for considering this PR!

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

@t-bltg t-bltg added enhancement improving existing functionality documentation - API labels Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (fa65e7d) to head (9e18d4c).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4922      +/-   ##
==========================================
- Coverage   89.77%   89.42%   -0.36%     
==========================================
  Files          40       40              
  Lines        8780     8792      +12     
==========================================
- Hits         7882     7862      -20     
- Misses        898      930      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeastyBlacksmith BeastyBlacksmith merged commit 9a1b641 into JuliaPlots:master Apr 26, 2024
3 checks passed
@t-bltg
Copy link
Member

t-bltg commented Apr 26, 2024

Awesome @pricklypointer thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation - API enhancement improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants