Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spurious GR warning #4641

Merged
merged 2 commits into from
Jan 26, 2023
Merged

fix spurious GR warning #4641

merged 2 commits into from
Jan 26, 2023

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jan 26, 2023

Per #4584 (comment).

Fix a spurious warning when GR is in the Manifest, but not in the Project.

@t-bltg t-bltg added the enhancement improving existing functionality label Jan 26, 2023
Copy link
Member

@BeastyBlacksmith BeastyBlacksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this I did the following:

JULIA_DEPOT_PATH=$(mktemp -d) julia
pkg> add Plots
# Ctrl-C when precompilation started
julia> using Plots

@BeastyBlacksmith
Copy link
Member

Need to fix CI though ^^

@t-bltg
Copy link
Member Author

t-bltg commented Jan 26, 2023

The warning also appeared in PlotUtils (https://github.com/JuliaPlots/PlotUtils.jl/actions/runs/4015693175/jobs/6897730588#step:6:387), so I could find a fix.

CI failure is odd, will have a look into that.

@t-bltg
Copy link
Member Author

t-bltg commented Jan 26, 2023

That's all related to GR being a hard Plots dependency.

This warning would not have occurred if #4631 was fixed (but we cannot do that until [email protected]).

@t-bltg t-bltg changed the title fix warning fix spurious GR warning Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 90.80% // Head: 90.80% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b0df12f) compared to base (54a215f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4641   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          41       41           
  Lines        8778     8781    +3     
=======================================
+ Hits         7971     7974    +3     
  Misses        807      807           
Impacted Files Coverage Δ
src/backends.jl 82.58% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg t-bltg merged commit 7c6a1a6 into JuliaPlots:master Jan 26, 2023
@t-bltg t-bltg deleted the warn_ver branch January 26, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants