Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permute, deprecate orientation #4164

Merged
merged 16 commits into from
May 5, 2022
Merged

add permute, deprecate orientation #4164

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3886082
add series_permutation
BeastyBlacksmith Apr 1, 2022
143eddf
works for dates and categorical input, not vector of strings
BeastyBlacksmith Apr 20, 2022
92659e5
Update src/pipeline.jl
BeastyBlacksmith Apr 20, 2022
3500bd3
Update src/pipeline.jl
BeastyBlacksmith Apr 20, 2022
ffe7f9e
add test
BeastyBlacksmith Apr 25, 2022
5361a5a
correct test
BeastyBlacksmith Apr 25, 2022
e73f880
make bar workign
BeastyBlacksmith May 5, 2022
41e3721
add deprecation
BeastyBlacksmith May 5, 2022
9e52024
rename series_permutation -> permute
BeastyBlacksmith May 5, 2022
80eb749
add Documentation
BeastyBlacksmith May 5, 2022
43183dd
fix uneccessary deprecation
BeastyBlacksmith May 5, 2022
8010fdf
permute h/vlines
BeastyBlacksmith May 5, 2022
e8a9d13
Auto-format
BeastyBlacksmith May 5, 2022
534d9f3
1.29.0
BeastyBlacksmith May 5, 2022
c5b330a
Merge branch 'master' into bbs/permutations
BeastyBlacksmith May 5, 2022
88e73cd
Update Project.toml [skip ci]
BeastyBlacksmith May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/args.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ const _series_defaults = KW(
:stride => (1, 1), # array stride for wireframe/surface, the first element is the row stride and the second is the column stride.
:connections => nothing, # tuple of arrays to specifiy connectivity of a 3d mesh
:z_order => :front, # one of :front, :back or integer in 1:length(sp.series_list)
:series_permutation => :none, # tuple of two symbols to be permuted
:extra_kwargs => Dict(),
)

Expand Down
5 changes: 5 additions & 0 deletions src/backends.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ const _base_supported_args = [
:projection,
:show_empty_bins,
:z_order,
:series_permutation,
]

function merge_with_base_supported(v::AVec)
Expand Down Expand Up @@ -948,6 +949,7 @@ const _unicodeplots_seriestype = [
:heatmap,
:contour,
# :contour3d,
:series_permutation,
:spy,
:surface,
:wireframe,
Expand Down Expand Up @@ -1022,6 +1024,7 @@ const _hdf5_attr = merge_with_base_supported([
:titlelocation,
:titlefont,
:window_title,
:series_permutation,
:guide,
:lims,
:ticks,
Expand Down Expand Up @@ -1124,6 +1127,7 @@ const _inspectdr_attr = merge_with_base_supported([
:window_title,
:guide,
:lims,
:series_permutation,
:scale, #:ticks, :flip, :rotation,
:titlefontfamily,
:titlefontsize,
Expand Down Expand Up @@ -1227,6 +1231,7 @@ const _pgfplotsx_attr = merge_with_base_supported([
:lims,
:ticks,
:scale,
:series_permutation,
:flip,
:titlefontfamily,
:titlefontsize,
Expand Down
4 changes: 4 additions & 0 deletions src/pipeline.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,10 @@ RecipesPipeline.is_seriestype_supported(plt::Plot, st) = is_seriestype_supported

function RecipesPipeline.add_series!(plt::Plot, plotattributes)
sp = _prepare_subplot(plt, plotattributes)
if plotattributes[:series_permutation] != :none
letter1, letter2 = plotattributes[:series_permutation]
plotattributes[letter1], plotattributes[letter2] = plotattributes[letter2], plotattributes[letter1]
BeastyBlacksmith marked this conversation as resolved.
Show resolved Hide resolved
BeastyBlacksmith marked this conversation as resolved.
Show resolved Hide resolved
end
_expand_subplot_extrema(sp, plotattributes, plotattributes[:seriestype])
_update_series_attributes!(plotattributes, plt, sp)
_add_the_series(plt, sp, plotattributes)
Expand Down