Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairplot support #3255

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheCedarPrince
Copy link

Based off a Slack conversation where I saw that Plots.jl doesn't have native support for pair plotting, I am opening this PR to support the missing functionality!

Currently just a draft. @daschw - I will ping you more when this is ready for review/merging. Right now, is there anything in particular you want me to prioritize with this functionality? Thanks!

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #3255 (a72ba38) into master (6fb0d69) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3255   +/-   ##
=======================================
  Coverage   62.91%   62.91%           
=======================================
  Files          25       25           
  Lines        6081     6081           
=======================================
  Hits         3826     3826           
  Misses       2255     2255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb0d69...a72ba38. Read the comment docs.

@daschw
Copy link
Member

daschw commented Jan 27, 2021

Hi, sorry, apparently I was not fast enough on Slack 😉
I would put the code in src/recipes.jl and implement it as a user recipe. This way users of pairplot can still modify Plots attributes and are not limited to the default values for e.g. ytickfont you set in the function. For inspiration you could have a look at the corrplot recipe in StatsPlots https://github.com/JuliaPlots/StatsPlots.jl/blob/master/src/corrplot.jl.

@TheCedarPrince
Copy link
Author

No worries! Probably good that it is here so we have a record of it @daschw. I will be working on this over the next couple days/weeks.

@t-bltg t-bltg added the first PR first pull request label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first PR first pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants