Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Ibcast! #882

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add Ibcast! #882

wants to merge 4 commits into from

Conversation

PetrKryslUCSD
Copy link

A convenience function is added, Ibcast!.

@vchuravy
Copy link
Member

Thanks could you also add a test?

@giordano
Copy link
Member

And documentation.

@PetrKryslUCSD
Copy link
Author

Ibcast! and Iallreduce! tests have been added. They also have a doc string. Is anything else required?

@giordano
Copy link
Member

Need to add the docstrings to the documentation

@PetrKryslUCSD
Copy link
Author

Done.

@PetrKryslUCSD
Copy link
Author

I just noticed this PR: #827
It also adds Iallreduce!.

@PetrKryslUCSD
Copy link
Author

@Keluaa : It'd be good to merge these PRs somehow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs docs needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PetrKryslUCSD @vchuravy @giordano @carstenbauer