Fix GPU tests #764
Merged
Fix GPU tests #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Besides the 1.6 issue, test now fail again because of MPI + GPU and not because of test env setup. |
simonbyrne
reviewed
Sep 6, 2023
simonbyrne
reviewed
Sep 6, 2023
|
Our AMD CI tests are still failing... |
|
@luraess did you want to look into this? Or just merge as-is? |
CUDA is also failing |
I'd say we could merge the infrastructure update and look into fixing respective ROCm and CUDA tests in a separate PR @simonbyrne ? |
simonbyrne
approved these changes
Sep 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the issue we are having when several JuliaGPU packages (here CUDA.jl and AMDGPU.jl) need to be accessible for testing purpose in the GPU CI using Buildkite. These packages may not depend on the same versions of e.g. GPUCompiler.jl which may result in non-resolvable combat bounds as it is the case without this PR.
One way to address this is to introduce weakdeps and add packages specifically for the target backend platform. This is here done parsing an extra flag passed when calling the test:
Issue: this works fine for Julia 1.9 and above, it currently fails for the MPI + CUDA tests run on Julia 1.6 as weakdeps may not be supported by 1.6. Shall we drop the 1.6 tests and keep current (+ nightly)?