Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unescape instead of escape for the cpio files #165

Closed
wants to merge 1 commit into from
Closed

use unescape instead of escape for the cpio files #165

wants to merge 1 commit into from

Conversation

larssp
Copy link

@larssp larssp commented Sep 5, 2018

This is a possible solution to #161

Example: Building "Cbc"

downloaded files to the cache are:

  • noarch%2Fmingw64-Cbc-2.9.2-1.19.noarch.rpm
  • noarch%2Fmingw64-Clp-1.16.3-1.21.noarch.rpm
  • noarch%2Fmingw64-libCgl1-0.59.2-3.20.noarch.rpm
  • noarch%2Fmingw64-libCoinUtils3-2.10.3-2.21.noarch.rpm
  • noarch%2Fmingw64-libstdc%2B%2B6-8.2.0-2.1.noarch.rpm
  • noarch%2Fmingw64-libwinpthread1-5.0.3-1.13.noarch.rpm
  • noarch%2Fmingw64-Osi-0.107.2-2.21.noarch.rpm
  • repodata%2F6c3cf735 ... b38cb-primary.xml
  • repodata%2Frepomd.xml

7z extracts noarch%2Fmingw64-libstdc%2B%2B6-8.2.0-2.1.noarch.rpm
to mingw64-libstdc++6-8.2.0-2.1.noarch.cpio

so the filename has to be unescaped, instead of escaped.

But I am not sure if the files should have escaped file names in the first place....
The escaped rpm file names are odd, because this was targeted by #141

@larssp
Copy link
Author

larssp commented Sep 5, 2018

Sorry, I just realized that there is PR #157 already targeting this issue.

@larssp larssp closed this Sep 5, 2018
@nalimilan
Copy link
Member

So the problem is just that we needed unescape here instead of escape? Please comment on #157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants