Use Compat.Sys.BINDIR so that BinDeps can work with system images #359
Conversation
| @@ -122,9 +118,9 @@ if Sys.KERNEL == :FreeBSD | |||
| end | |||
|
|
|||
| if Compat.Sys.iswindows() | |||
| const exe7z = joinpath(_HOME, "7z.exe") | |||
There was a problem hiding this comment.
it's possible other packages may have been referring to this constant
There was a problem hiding this comment.
I really hope not since this would only existing on windows. I could undo this without causing problems for us, but I'm pretty sure creating system images on windows won't work correctly.
There was a problem hiding this comment.
creating system images on windows won't work correctly
Why's that? What is this fixing anyway?
There was a problem hiding this comment.
The issue is that JULIA_HOME (or I guess now Sys.BINDIR) doesn't exist at system image build time, which will cause functions that depend on the compiled constant to fail at runtime. Since I don't use windows I'm not particularly bothered by leaving this in the windows if block, but this could cause problems for windows user who want to make system images.
|
Ping? Would folks like me to prioritize non-exported constants on Windows over building system images on windows? |
|
Being able to build sysimgs on Windows seems like a good thing :) |
|
it's not possible to preserve the compatibility and have both? |
|
Hmmm, the only way we can keep the windows constant is by setting it in an |
No description provided.