Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type-inference in blockbandwidths for BlockBandedMatrix #210

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 15, 2024

Using map instead of broadcasting over _broadcast_blockbandwidths improves type-inference, as this is a much simpler operation. This should be safe, as bc.args is a Tuple, and the map would be equivalent to a broadcast.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (7467a90) to head (06b5c14).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   89.55%   89.58%   +0.02%     
==========================================
  Files          11       11              
  Lines        1111     1114       +3     
==========================================
+ Hits          995      998       +3     
  Misses        116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit cfc2e58 into master Oct 15, 2024
13 checks passed
@jishnub jishnub deleted the jishnub/blockbandwidths_blockbanded branch October 15, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant