Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle out-of-bounds blockcolstop/blockrowstop #192

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 19, 2024

The following works after this:

julia> using BlockBandedMatrices, LinearAlgebra

julia> B = BlockSkylineMatrix{Bool}(I, 1:1, 1:5, ([0,0,0,0,0],[0,1,1,1,1]))
1×5-blocked 1×15 BlockSkylineMatrix{Bool, Vector{Bool}, BlockBandedMatrices.BlockSkylineSizes{Tuple{BlockArrays.BlockedUnitRange{ArrayLayouts.RangeCumsum{Int64, UnitRange{Int64}}}, BlockArrays.BlockedUnitRange{ArrayLayouts.RangeCumsum{Int64, UnitRange{Int64}}}}, Vector{Int64}, Vector{Int64}, BandedMatrices.BandedMatrix{Int64, Matrix{Int64}, Base.OneTo{Int64}}, Vector{Int64}}}:
 10  0                  

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.22%. Comparing base (7df446b) to head (36d3b81).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   88.37%   88.22%   -0.15%     
==========================================
  Files          11       11              
  Lines        1204     1206       +2     
==========================================
  Hits         1064     1064              
- Misses        140      142       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit a76f945 into JuliaLinearAlgebra:master Mar 19, 2024
11 of 12 checks passed
@jishnub jishnub deleted the blockcolstop branch March 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant