Add option to only install essential signal handlers #49981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Feb 10, 2024
|
Related #50278 |
|
I think only SIGSEGV is actually essential. And SIGUSR2 is only needed on linux (other kernels typically support this functionality natively, and do not require that hack) |
|
I'm happy to change this to only keep SIGSEGV. Hopefully will have time to rebase it as well in the next week or so |
When embedding Julia, it is useful to opt out of some of the signal handlers (especially SIGINT). But opting out of SIGSEGV makes it very difficult to use multiple Julia threads, since the GC safepoint implementation relies on segv_handler(). This patch provides a third option to embedders, which installs the essential signal handlers but skips the optional ones. It might make sense for this to be the default when embedding, but I've kept the other two options for backwards compatibility.
jonathan-conder-sm
force-pushed
the
handle_signals_maybe
branch
from
b900d67
to
7464912
Compare
|
Updated now. I haven't tested yet or thought as hard about this as the previous iteration, probably won't get a chance to test until next week. However, it's a lot simpler now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedding Julia, it is useful to opt out of some of the signal handlers (especially SIGINT). But opting out of SIGSEGV makes it very difficult to use multiple Julia threads, since the GC safepoint implementation relies on segv_handler().
This patch provides a third option to embedders, which installs the essential signal handlers but skips the optional ones. It might make sense for this to be the default when embedding, but I've kept the other two options for backwards compatibility.