-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TailwindCSS colors (and script to update them) #25
Conversation
Adds JavaScript script to track the colors that ship with the `tailwindcss` `npm` package. Also edits `.gitignore` to prevent tracking `node_modules` and `package-lock.json`
… into add-tailwindcss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me; I noticed that the sources in the Readme are not up to date (even missing my last Paul Tol colours update ehem), could you at least add your source there as well?
(Feel free to list https://personal.sron.nl/~pault/ as well, since I forgot that).
So, I've added the link to Tailwind's (and Paul Tol's) colors in the README. I also removed the copy-paste error in I was able to extract most of the JS code into a Julia script – so if that's preferable, let me know and I'll remove the JS code and opt for the Julia script. (Otherwise, I can trim the Julia code back down to the ~10 line script it was and let JS do its thing.) To get the Julia script running, I needed to add |
1f3a68f
to
3e5f871
Compare
3e5f871
to
bc733e6
Compare
If the update script is in its own folder, it could get its own Project toml for example? Just within the Sure it should not be additional dependencies for NamedColors. But the rest already looks very good :) |
Done! Should I leave the JS code for reference, or take it out entirely? (I left it as reference mostly in case I ever needed to go back, but I could also make it a gist and just link to it from the If you're good with leaving the JS code as reference, then this is ready to merge. 🎉 |
If the Julia script now does the Job well, we could remove the old JS code to avoid confusion? So maybe a gist and linking it might be indeed the less confusing resolution here. Besides that – I agree, we are nearly done – thanks for reacting to all my ideas and comments. |
Removes the JS script used to fetch Tailwind colors from their JS package and adds a link to a private GitHub Gist in the source of `scripts/update-tailwind.jl`.
Removed! 🙂 I linked the Gist in the header of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I will wait a bit if some other developers have something to comment, but to me it looks good and I would merge it maybe end of the week?
We could also set the patch version one up (in the main project.toml) to register this as a new patch version.
Could you maybe as a last step increase the patch number in the project toml? Them I would merge it and register a new version :) |
Thanks 👍 |
👋 Following up on #24, I've added the colors from TailwindCSS (an incredibly popular CSS framework).
Their code is MIT licensed and their colors don't appear to have a different license, so it seems that these colors are also MIT licensed.
I've also run the tests using
julia --project=. tests/runtests.jl
and received the following output: