Use WebP for CVD simulation demo in docs instead of indexed PNGs #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 98.82% 98.90% +0.07%
==========================================
Files 10 10
Lines 1281 1281
==========================================
+ Hits 1266 1267 +1
+ Misses 15 14 -1 ☔ View full report in Codecov by Sentry. |
kimikage
changed the title
kimikage
force-pushed
the
doc_cvd_webp
branch
2 times, most recently
from
dfcbc10
to
f118d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #413 (comment)
When I added this demo, I needed to use ImageMagick.jl to read and write compressed images. IIRC, there were no JLLs at that time.