Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to SnoopPrecompile #529

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch to SnoopPrecompile #529

wants to merge 1 commit into from

Conversation

timholy
Copy link
Member

@timholy timholy commented Jan 4, 2023

On my machine, the workload inside the @precompile_all_calls
goes from 0.3s with the previous precompile script to 0.08s with the new
one, a 4x reduction. Given that we don't have precompiles anymore in
ColorTypes (see JuliaGraphics/ColorTypes.jl#270,
a decision I agree with), this package seems like a good place to have
some.

Measurements conducted on something like nightly but it should be
applicable to the upcoming Julia 1.9.

On my machine, the workload inside the `@precompile_all_calls`
goes from 0.3s with the previous precompile script to 0.08s with the new
one, a 4x reduction. Given that we don't have precompiles anymore in
ColorTypes (see JuliaGraphics/ColorTypes.jl#270,
a decision I agree with), this package seems like a good place to have
some.
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 98.82% // Head: 98.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ac20a14) compared to base (b0d1b59).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          10       10           
  Lines        1274     1275    +1     
=======================================
+ Hits         1259     1260    +1     
  Misses         15       15           
Impacted Files Coverage Δ
src/Colors.jl 100.00% <ø> (ø)
src/precompile.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy
Copy link
Member Author

timholy commented Jan 4, 2023

On nightly, I can't detect any difference in load time between master and this branch: master is 0.189s, this branch is 0.186s.

@kimikage
Copy link
Collaborator

kimikage commented May 1, 2024

This will likely be merged, but in any case it's PrecompileTools now.

@kimikage kimikage marked this pull request as draft May 1, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants