Add POCL support and CI + major package rework #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to this change, we lose some type information, introducing ambiguities with the Buffer ctors. To avoid that, we swap the flags and length field and make the former a required argument in all cases.
Removes the Buildkite CI for now.
maleadt
changed the title
giordano
reviewed
Jul 31, 2024
giordano
reviewed
Jul 31, 2024
giordano
reviewed
Jul 31, 2024
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
|
Yay, works on macOS now too! |
|
And finally CUDA CI. I think I'm going to postpone other refactors to a different PR, so let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to add POCL support to OpenCL.jl, since I may want to use it to implement the CPU back-end of KernelAbstractions.jl. Since there are
very fewno real public packages depending on OpenCL.jl, I'm additionally doing a rework/modernization of the package in the hopes to revitalize it a bit, and bring it closer to the other GPU back-ends we have in Julia. Needless to say, this is going to be breaking.Breaking changes:
Bufferctor: switch length and flag arguments around (for ambiguity reasons), and make passing the length mandatoryTODO:
create_some_contextetc