-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark more methods as device methods #2336
base: vc/precompile_tools
Are you sure you want to change the base?
Conversation
Hmm, I purposefully didn't want to overuse overloads as they break e.g. Revise... |
Yeah :/ Did you ever check why Revise breaks? Jameson mentioned a few weeks ago that OverlayMethod tables don't participate in invalidations correctly. (cc: @aviatesk) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vc/precompile_tools #2336 +/- ##
=======================================================
+ Coverage 59.96% 60.34% +0.37%
=======================================================
Files 156 156
Lines 14989 14893 -96
=======================================================
- Hits 8988 8987 -1
+ Misses 6001 5906 -95 ☔ View full report in Codecov by Sentry. |
Yeah, that seems plausible: timholy/Revise.jl#646 (comment) |
51520a1
to
03530f0
Compare
Motivated by JuliaLang/julia#54155