Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 29.x Emacs versions to CI matrix #208

Merged
merged 2 commits into from
Apr 9, 2024
Merged

add 29.x Emacs versions to CI matrix #208

merged 2 commits into from
Apr 9, 2024

Conversation

tpapp
Copy link
Collaborator

@tpapp tpapp commented Apr 9, 2024

No description provided.

@tpapp tpapp requested a review from non-Jedi April 9, 2024 06:12
@tpapp
Copy link
Collaborator Author

tpapp commented Apr 9, 2024

Currently the nested defun is broken (finds the inner one). I would wait to fix that in an issue and add CI regardless.

non-Jedi
non-Jedi approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@non-Jedi non-Jedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Definitely a positive change to factor that hairy macro interpolation into a function. Note that the test failure on 29 already has an issue: #199

@non-Jedi
Copy link
Contributor

non-Jedi commented Apr 9, 2024

Could gate the failing test behind (unless (>= emacs-major-version 29) ...) if you wanted since there is an upstream emacs bug report about this behavior, and it's not immediately clear to me if the bug is on emacs side or julia-mode side.

@tpapp
Copy link
Collaborator Author

tpapp commented Apr 9, 2024

Thanks. I will look into #199 first before making an exception CI.

@tpapp tpapp merged commit c19d10e into JuliaEditorSupport:master Apr 9, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@non-Jedi non-Jedi non-Jedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpapp @non-Jedi