rootfind with p #125
Merged
rootfind with p #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo: use multiple dispatch to support previous behaviour |
hexaeder
reviewed
Aug 1, 2023
src/Utilities.jl
Outdated
| @@ -191,32 +192,32 @@ struct RootRhs | |||
| rhs | |||
| mpm | |||
| end | |||
| function (rr::RootRhs)(x) | |||
| function (rr::RootRhs)(x,p) | |||
There was a problem hiding this comment.
hm commit suggestion is gone...
maybe just
function (rr:RootRhs)(x, p=nothing, t=nothing)
to achieve the old behavior? Also might be worth adding an option for t. Maybe nothing would be the better default than 0.0 since it screams a the user in case there is an explicit t dependency.
Bit off topic, but since the rhs and mpm fields are not typed the inner loop of nlsolve will be type unstable. But this might not be a problem in practice as it converges fast for small systems and for large systems the matrix multiply cost might dominate the runtime dispatch cost 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.