Merge pull request #183 from JuliaDynamics/hw/verboseinit

don't error on verbose when u0 is empty
JuliaDynamics · Nov 25, 2024 · 953624a · 953624a
2 parents a1672e6 + 1465cab
commit 953624a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/initialization.jl b/src/initialization.jl
@@ -199,16 +199,17 @@ function initialize_component!(cf; verbose=true, kwargs...)
             @warn "Initialization for componend stalled with residual $(res)"
         elseif !SciMLBase.successful_retcode(sol.retcode)
             throw(ArgumentError("Initialization failed. Solver returned $(sol.retcode)"))
+        else
+            verbose && @info "Initialization successful with residual $(LinearAlgebra.norm(sol.resid))"
         end
         set_init!.(Ref(cf), SII.variable_symbols(sol), sol.u)
         resid = sol.resid
     else
         resid = init_residual(cf; recalc=true)
+        verbose && @info "No free variables! Residual $(LinearAlgebra.norm(resid))"
     end
 
     set_metadata!(cf, :init_residual, resid)
-
-    verbose && @info "Initialization successful with residual $(LinearAlgebra.norm(sol.resid))"
     cf
 end
 

diff --git a/test/initialization_test.jl b/test/initialization_test.jl
@@ -65,7 +65,14 @@ end
     @test vf.symmetadata[:i_r][:default] == 1
     @test vf.symmetadata[:i_i][:default] == 0.1
 
-    NetworkDynamics.initialize_component!(vf)
+    NetworkDynamics.initialize_component!(vf; verbose=true)
     @test NetworkDynamics.init_residual(vf) < 1e-8
     @test init_residual(vf) ≈ init_residual(vf; recalc=true)
+
+    # make empty problem
+    set_default!(vf, :Pm, get_init(vf, :Pm))
+    set_default!(vf, :θ, get_init(vf, :θ))
+    set_default!(vf, :ω, get_init(vf, :ω))
+
+    NetworkDynamics.initialize_component!(vf; verbose=true)
 end