Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge DictABM and VecABM for dispatch #993

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Enlarge DictABM and VecABM for dispatch #993

merged 4 commits into from
Feb 29, 2024

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Feb 29, 2024

Just realized it is needed for #992 thread safe dict

@Tortar Tortar requested a review from Datseris February 29, 2024 20:00
@Tortar
Copy link
Member Author

Tortar commented Feb 29, 2024

lol I saw that you wrote

(this means that we need to change the agent container types in the source code from Dict to AbstrcactDict and from Vector to AbstractVector)

but I jumped straight to the link and only read it now, I realized the same myself afterwards :D

@Datseris Datseris merged commit 7cd324d into main Feb 29, 2024
1 of 5 checks passed
@Datseris Datseris deleted the d branch February 29, 2024 21:37
@Datseris
Copy link
Member

test did not pass but i kinda assumed this was teh "known issue". I am sorry if I was wrong!!!

@Tortar
Copy link
Member Author

Tortar commented Feb 29, 2024

yeah :D just did a PR now, testing it locally at the same time, I will let you know if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants