Error if deletion of agent fails #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interpolating the whole agent struct into the string does not seem like a good idea to me. Perhaps only the ID? Beyond this however, what is the point of this error message? A user should never directly remove an agent "only from space" and this error message said that we can't remove "from the space", not that we generally can't remove the agent. Who is this error targetting? |
|
The main motivation here is to remove (innocuous) dynamic dispatches found by JET, because guarantees not to throw if the error path is not followed. |
|
Right, ok then. |
Datseris
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems the only thing to improve in
remove_agent_from_space!which could have been seen as a bug (but it is not), related to the issue in #1035