-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use oneunit(T)
in construct_seeds
#652
Conversation
the invalidations tests has an unrelated error |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 11 11
Lines 967 967
=======================================
Hits 867 867
Misses 100 100
☔ View full report in Codecov by Sentry. |
This seems fine. Is it easy to add a test, e.g. loading the smallest / slowest-changing package which defines a number for which one != oneunit? |
Measurements.jl? and an unary function. Another possible candidate for this is Unitful.jl. if we see #328 , the error posted there is caused by the different types of the tuple
and Unitful.jl defines |
I added Measurements.jl as an example package that has The invalidation tests fails with the Edit: it seems that the errors in nightly and in the invalidations tests are unrelated |
replaced by #659 |
should fix #651 ?