Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix other string C api call arguments #205

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix other string C api call arguments #205

merged 1 commit into from
Oct 25, 2022

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Oct 25, 2022

No description provided.

@quinnj
Copy link
Member Author

quinnj commented Oct 25, 2022

Fixes #203

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #205 (b7e3f14) into main (2c15d97) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files           9        9           
  Lines        1114     1114           
=======================================
  Hits          717      717           
  Misses        397      397           
Impacted Files Coverage Δ
src/api/ccalls.jl 20.68% <ø> (ø)
src/execute.jl 91.05% <100.00%> (ø)
src/prepare.jl 98.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Octogonapus
Copy link
Contributor

I confirm this fixes #203 in my use case. Thank you!

@quinnj
Copy link
Member Author

quinnj commented Oct 25, 2022

Awesome; thanks for the patience and helping check these fixes.

@quinnj quinnj merged commit 7d9545a into main Oct 25, 2022
@quinnj quinnj deleted the jq/strings branch October 25, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants