-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with SQLStrings.jl #216
Conversation
I'm not sure what's up with the docs build here, SQLStrings is registered at version 0.1. That was quite recent though, maybe it's a stale registry somehow. |
Bump! I'd like to get this merged, or alternatively get some feedback on a different more preferred approach. |
Given the silence here, I guess there's no interest in this integration? Perhaps I'll resort to |
My apologies for completely missing this. I have started remonitoring this repo for activity. Happy to merge 7134a4e, but it would be nice to also add a similar method for async_execute here: https://github.com/invenia/LibPQ.jl/blob/master/src/asyncresults.jl#L239 |
This integrates the SQLStrings package into LibPQ, making it usable with the execute() function.
Great, let's get this merged then. I've rebased to remove the testing infrastructure from this PR and added I've tried to appease JuliaFormatter for the files in |
Yeah the JuliaFormatter review integration is broken and I don't like the actual correct suggestions anyway. This looks good to me! |
Ah current Invenia policy is to bump version numbers in merge requests, could you do that (to 1.12.0) now? Then I'll merge and registrate. |
Project.toml is bumped now |
This integrates the new https://github.com/JuliaComputing/SQLStrings.jl package (discussed in #213) into LibPQ, making it usable with the
execute()
function.Currently based on #215 so if reviewing, just ignore the first commit.
This is quite a minimal integration. There's probably other options but this one is most straightforward if you don't mind the dependency.