feat(nonblocking) implement non blocking mode for connections #117
Annotations
2 errors and 10 warnings
|
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
|
|
|
src/connections.jl#L269
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/connections.jl:269:- options::Dict{String, String}=CONNECTION_OPTION_DEFAULTS,
src/connections.jl:269:+ options::Dict{String,String}=CONNECTION_OPTION_DEFAULTS,
|
|
src/connections.jl#L271
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/connections.jl:271:- kwargs...
src/connections.jl:271:+ kwargs...,
|
|
src/connections.jl#L316
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/connections.jl:316:- kwargs...
src/connections.jl:316:+ kwargs...,
|
|
src/connections.jl#L321
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/connections.jl:321:- handle_new_connection(
src/connections.jl:322:- jl_conn;
src/connections.jl:323:- throw_error=throw_error,
src/connections.jl:324:- )
src/connections.jl:321:+ handle_new_connection(jl_conn; throw_error=throw_error)
|
|
src/connections.jl#L327
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/connections.jl:327:- if nonblocking
src/connections.jl:324:+ if nonblocking
|
|
src/connections.jl#L853
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/connections.jl:853:- # -1 indicates error
src/connections.jl:865:+ # -1 indicates error
|
|
src/connections.jl#L856
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/connections.jl:856:- # 1 indicates that we could not send all data without blocking,
src/connections.jl:868:+ # 1 indicates that we could not send all data without blocking,
|
|
test/runtests.jl#L45
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
test/runtests.jl:45:+ @testset "ConninfoDisplay" begin
test/runtests.jl:46:+ @test parse(LibPQ.ConninfoDisplay, "") == LibPQ.Normal
test/runtests.jl:47:+ @test parse(LibPQ.ConninfoDisplay, "*") == LibPQ.Password
test/runtests.jl:48:+ @test parse(LibPQ.ConninfoDisplay, "D") == LibPQ.Debug
test/runtests.jl:49:+ @test_throws LibPQ.Errors.JLConnectionError parse(LibPQ.ConninfoDisplay, "N")
test/runtests.jl:50:+ end
|
|
test/runtests.jl#L46
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
test/runtests.jl:46:-@testset "ConninfoDisplay" begin
test/runtests.jl:47:- @test parse(LibPQ.ConninfoDisplay, "") == LibPQ.Normal
test/runtests.jl:48:- @test parse(LibPQ.ConninfoDisplay, "*") == LibPQ.Password
test/runtests.jl:49:- @test parse(LibPQ.ConninfoDisplay, "D") == LibPQ.Debug
test/runtests.jl:50:- @test_throws LibPQ.Errors.JLConnectionError parse(LibPQ.ConninfoDisplay, "N")
test/runtests.jl:51:-end
test/runtests.jl:52:+ @testset "Version Numbers" begin
test/runtests.jl:53:+ valid_versions = [
test/runtests.jl:54:+ (LibPQ.pqv"11", v"11"),
test/runtests.jl:55:+ (LibPQ.pqv"11.80", v"11.0.80"),
test/runtests.jl:56:+ (LibPQ.pqv"10.1", v"10.0.1"),
test/runtests.jl:57:+ (LibPQ.pqv"9.1.5", v"9.1.5"),
test/runtests.jl:58:+ (LibPQ.pqv"9.2", v"9.2.0"),
test/runtests.jl:59:+ (LibPQ.pqv"8", v"8.0.0"),
test/runtests.jl:60:+ ]
test/runtests.jl:61:+
test/runtests.jl:62:+ @testset "Valid Versions" for (pg_version, jl_version) in valid_versions
test/runtests.jl:63:+ @test pg_version == jl_version
test/runtests.jl:64:+ end
|
|
test/runtests.jl#L81
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
test/runtests.jl:81:-@testset "Online" begin
test/runtests.jl:82:- DATABASE_USER = get(ENV, "LIBPQJL_DATABASE_USER", "postgres")
test/runtests.jl:83:-
test/runtests.jl:84:- @testset "Example SELECT" begin
test/runtests.jl:85:- conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=false, nonblocking=usenonblocking)
test/runtests.jl:86:-
test/runtests.jl:87:- @test conn isa LibPQ.Connection
test/runtests.jl:88:- @test isopen(conn)
test/runtests.jl:89:- @test status(conn) == LibPQ.libpq_c.CONNECTION_OK
test/runtests.jl:90:- @test conn.closed[] == false
test/runtests.jl:91:-
test/runtests.jl:92:- text_display = sprint(show, conn)
test/runtests.jl:93:- @test occursin("dbname = postgres", text_display)
test/runtests.jl:94:- @test occursin("user = $DATABASE_USER", text_display)
test/runtests.jl:95:-
test/runtests.jl:96:- result = execute(
test/runtests.jl:97:- conn,
test/runtests.jl:98:- "SELECT typname FROM pg_type WHERE oid = 16";
test/runtests.jl:99:- throw_error=false,
test/runtests.jl:100:- )
test/runtests.jl:101:- @test result isa LibPQ.Result
test/runtests.jl:102:- @test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
test/runtests.jl:103:- @test isopen(result)
test/runtests.jl:104:- @test LibPQ.num_columns(result) == 1
test/runtests.jl:105:- @test LibPQ.num_rows(result) == 1
test/runtests.jl:106:- @test LibPQ.column_name(result, 1) == "typname"
test/runtests.jl:107:- @test LibPQ.column_number(result, "typname") == 1
test/runtests.jl:108:-
test/runtests.jl:109:- data = columntable(result)
test/runtests.jl:110:-
test/runtests.jl:111:- @test data[:typname][1] == "bool"
test/runtests.jl:112:-
test/runtests.jl:113:- close(result)
test/runtests.jl:114:- @test !isopen(result)
test/runtests.jl:115:-
test/runtests.jl:116:- # the same but with parameters
test/runtests.jl:117:- result = execute(
test/runtests.jl:118:- conn,
test/runtests.jl:119:- "SELECT typname FROM pg_type WHERE oid = \$1",
test/runtests.jl:120:- [16];
test/runtests.jl:121:- throw_error=false,
test/runtests.jl:122:- )
test/runtests.jl:123:- @test result isa LibPQ.Result
test/runtests.jl:124:- @test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
test/runtests.jl:125:- @test isopen(result)
test/runtests.jl:126:- @test LibPQ.num_columns(result) == 1
test/runtests.jl:127:- @test LibPQ.num_rows(result) == 1
test/runtests.jl:128:- @test LibPQ.column_name(result, 1) == "typname"
test/runtests.jl:129:-
test/runtests.jl:130:- data = columntable(result)
test/runtests.jl:131:-
test/runtests.jl:132:- @test data[:typname][1] == "bool"
test/runtests.jl:133:-
test/runtests.jl:134:- close(result)
test/runtests.jl:135:- @test !isopen(result)
test/runtests.jl:136:-
test/runtests.jl:137:- # the same but with tuple parameters
test/runtests.jl:138:-
test/runtests.jl:139:- qstr = "SELECT \$1::double precision as foo, typname FROM pg_type WHERE oid = \$2"
test/runtests.jl:140:- stmt = prepare(conn, qstr)
test/runtests.jl:141:-
test/runtests.jl:142:- result = execute(
test/runtests.jl:143:- conn,
test/runtests.jl:144:- qstr,
test/runtests.jl:145:- (1.0, 16);
test/runtests.jl:146:- throw_error=false,
test/runtests.jl:147:- )
test/runtests.jl:148:- @test result isa LibPQ.Result
test/runtests.jl:149:- @test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
test/runtests.jl:150:- @test isopen(result)
test/runtests.jl:151:- @test LibPQ.num_columns(result) == 2
test/runtests.jl:152:- @test LibPQ.num_rows(result) == 1
test/runtests.jl:153:- @test LibPQ.column_name(result, 1) == "foo"
test/runtests.jl:154:- @test LibPQ.column_name(result, 2) == "typname"
test/runtests.jl
|
The logs for this run have expired and are no longer available.
Loading