Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat entry for Test #467

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

putianyi889
Copy link

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (805bb7c) to head (b75922a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   94.33%   94.34%           
=======================================
  Files          24       24           
  Lines         742      743    +1     
=======================================
+ Hits          700      701    +1     
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Collaborator

oxinabox commented Apr 4, 2024

Does having a Test compat entry of 1 work on Julia 1.0 or on 1.6?
I recall something about compat values being funny from before we required them for StdLibs

@gdalle
Copy link
Collaborator

gdalle commented Apr 4, 2024

I'm not sure there is a universally accepted answer, since they rolled back the registry requirements for stdlib compat: https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-9th-2023-2

So it is indeed a bit weird that Aqua still checks. Maybe we should align on what Aqua does?

Also related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants