Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont run SpecialFunctions benchmarks by default #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KristofferC
Copy link
Contributor

@KristofferC KristofferC commented Sep 19, 2018

Running all the benchmarks for the special functions take a significant time and I am questioning the usefullness of testing this so carefully for every single nanosoldier run.

  • Most of them typically directly call a C-function or they are defined in Base but are "isolated" in the sense that they almost only call very basic functions.
  • There are a significant number of them that is aimed to test all the branches of the implementation, which is good for testing the implementation itself but not the julia language.
  • They are kinda noisy so it pollutes all the Benchmark reports.

This PR makes them not be included in the ALL benchmarkgroup but IIUC you should still be able to run them explicitly using the specialfunction group.

An alternative is to have a "meta group" called "JuliaLanguage" or something which tries to include stuff that tests the language, but still have everything go into ALL.

cc @jrevels, @pkofod, @ararslan

@jrevels
Copy link
Member

jrevels commented Sep 19, 2018

This definitely seems like a good idea!

This PR makes them not be included in the ALL benchmarkgroup but IIUC you should still be able to run them explicitly using the specialfunction group.

This unfortunately is not the case, AFAICT. This PR causes the "specificalfunction" group to not be loaded at all if using loadall (which is what Nanosoldier uses), so filtering based on a tag predicate could never return that group (since that group was never there in the first place).

It might make more sense to implement this in Nanosoldier.jl (changing the benchmark script here: https://github.com/JuliaCI/Nanosoldier.jl/blob/master/src/jobs/BenchmarkJob.jl#L336) than here.

@pkofod
Copy link
Contributor

pkofod commented Sep 19, 2018

They're not important for most nanosoldier runs. It's just important to track that they don't regress over some major changes to the language itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants