Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affinity propagation #574

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

Yuan-Ru-Lin
Copy link
Contributor

This is a companion PR of JuliaAI/MLJClusteringInterface.jl#28.

Without this, ap = @load AffinityPropagation pkg=Clustering wouldn't work.

@ablaom
Copy link
Member

ablaom commented Nov 25, 2024

Oh, wow. I usually take care of this, but if it works..., thanks.

Other steps someone needs to take are:

This PR will fail until:

@Yuan-Ru-Lin
Copy link
Contributor Author

Done in JuliaAI/MLJ.jl#1147.

@ablaom
Copy link
Member

ablaom commented Dec 15, 2024

@Yuan-Ru-Lin Are you happy to rebase, now I've merged #576.

While you're at it, can you please bump Julia compat to 1.10 and bump change "1.6" in CI.yml to "1.10"?

@ablaom
Copy link
Member

ablaom commented Dec 15, 2024

And if you're happy for me to merge, please remove the "Draft" tag, thanks.

@Yuan-Ru-Lin Yuan-Ru-Lin marked this pull request as ready for review December 15, 2024 22:41
@Yuan-Ru-Lin
Copy link
Contributor Author

@ablaom all done!

@DilumAluthge
Copy link
Member

@ablaom Is it necessary to drop support for Julia 1.6?

@ablaom
Copy link
Member

ablaom commented Dec 16, 2024

@ablaom Is it necessary to drop support for Julia 1.6?

Mmm. Not strictly necessary, but this is already happening in the MLJ ecosystem elsewhere. I think, given narrow bandwidth for maintenance, it's hard to justify supporting < LTS. Do you have a specific reason for lamenting the loss of support?

@ablaom ablaom merged commit 46f2e67 into JuliaAI:dev Dec 16, 2024
2 checks passed
@ablaom ablaom mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants