-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add affinity propagation #574
Conversation
Oh, wow. I usually take care of this, but if it works..., thanks. Other steps someone needs to take are:
This PR will fail until:
|
Done in JuliaAI/MLJ.jl#1147. |
@Yuan-Ru-Lin Are you happy to rebase, now I've merged #576. While you're at it, can you please bump Julia compat to 1.10 and bump change "1.6" in CI.yml to "1.10"? |
And if you're happy for me to merge, please remove the "Draft" tag, thanks. |
@ablaom all done! |
@ablaom Is it necessary to drop support for Julia 1.6? |
Mmm. Not strictly necessary, but this is already happening in the MLJ ecosystem elsewhere. I think, given narrow bandwidth for maintenance, it's hard to justify supporting < LTS. Do you have a specific reason for lamenting the loss of support? |
This is a companion PR of JuliaAI/MLJClusteringInterface.jl#28.
Without this,
ap = @load AffinityPropagation pkg=Clustering
wouldn't work.