Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input_scitype for AffinityPropagation #30

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Dec 17, 2024

input_scitype works a bit differently for Static models; see https://juliaai.github.io/MLJModelInterface.jl/dev/static_models/#Static-models

This patch fixes the trait for Affinity Propagation.

The problem is causing integration tests to fail at MLJ.

@ablaom ablaom merged commit 856a449 into master Dec 17, 2024
2 checks passed
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (3d4b729) to head (8a246e2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files           1        1           
  Lines          93       93           
=======================================
  Hits           90       90           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant