Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from /api to /ajax-api endpoint #36

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Migrating from /api to /ajax-api endpoint #36

merged 1 commit into from
Jan 7, 2024

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Jan 7, 2024

The /ajax-api prefix is used by Dagshub to connect to the REST API. This is giving exactly the same responses as the previous /api prefix. This solves #35 (comment).

I don't know the existance of both, but we must go through the one that is compatible with both solutions. In the future, if there's a case that is breaking this, we should think in a way to separate each different platform.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a4237f) 77.64% compared to head (ac7c806) 77.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   77.64%   77.71%   +0.06%     
==========================================
  Files           9        9              
  Lines         331      332       +1     
==========================================
+ Hits          257      258       +1     
  Misses         74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deyandyankov deyandyankov merged commit e27ac10 into JuliaAI:main Jan 7, 2024
4 of 5 checks passed
@deyandyankov
Copy link
Collaborator

Thanks! Merged and triggered a new release: JuliaRegistries/General#98410

@freemin7
Copy link

freemin7 commented Apr 4, 2024

This makes implementing GitLab support a lot harder as Gitlab is unaware of the undocumented (a search on the mlflow page found no mentions of this endpoint) ajax-api end point and uses the api endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants