Feature implementation, code refactoring, new test suite and increasing code coverage #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #27 +/- ##
===========================================
+ Coverage 69.75% 79.86% +10.11%
===========================================
Files 5 9 +4
Lines 281 303 +22
===========================================
+ Hits 196 242 +46
+ Misses 85 61 -24
|
deyandyankov
requested changes
Jun 5, 2023
deyandyankov
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains variety of changes, mostly related to be a "developer friendly" code and follow some software standards. This changes will make the code base to be more maintainable.
typesdirectory where all the "model" stuff is savedtypes/core.jlcontains the general types (MLFlow and MLFlowExperiment)logger.jlfile, leaving the runs logic isolatedsearchexperimentsfunction for experiments, and removing the deprecated (and removed)listexperimentsfrom MLFlow. Maybe it could be reimplemented but pointing to the new one.generatefilterfromentity_type, a generalization to avoid code repetition and making it accessible to everyone if there's something more to filter (just like metrics)