Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding artifact_location modification to getorcreateexperiment #26

Merged
merged 3 commits into from
May 22, 2023
Merged

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented May 21, 2023

  • getorcreateexperiment() doesn't have an artifact_location parameter (and tags). In almost all production cases, users will need this option.
  • Updating LICENSE to match the current year.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Merging #26 (1d43f1d) into main (b94b409) will decrease coverage by 0.61%.
The diff coverage is 92.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   70.35%   69.75%   -0.61%     
==========================================
  Files           5        5              
  Lines         280      281       +1     
==========================================
- Hits          197      196       -1     
- Misses         83       85       +2     
Impacted Files Coverage Δ
src/runs.jl 53.54% <88.88%> (ø)
src/experiments.jl 82.60% <100.00%> (ø)
src/types.jl 78.31% <100.00%> (-2.18%) ⬇️

@pebeto
Copy link
Member Author

pebeto commented May 22, 2023

In c33acd1, I just added the run_name parameter on MLFlowRunInfo (>v1.30 feature).

Also, there's a split on the createrun test, setting this as a goal to split test cases in different files.

@deyandyankov deyandyankov merged commit 9437c21 into JuliaAI:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants