Sending the executions in UTC-0 (rel. issue 20) #25
Conversation
| ) | ||
| ] | ||
| ) | ||
| @test isa(mlf_run, MLFlowRun) |
There was a problem hiding this comment.
I was wondering if we could ensure that the timestamp is actually in UTC, but it seems that DateTime doesn't keep that information:
julia> dt = now()
2023-03-28T12:26:28.664
julia> dump(dt)
DateTime
instant: Dates.UTInstant{Millisecond}
periods: Millisecond
value: Int64 63815689588664
julia> dt = now(UTC)
2023-03-28T11:26:38.460
julia> dump(dt)
DateTime
instant: Dates.UTInstant{Millisecond}
periods: Millisecond
value: Int64 63815685998460
julia>
can you think of a way to test whether the timestamp is acutally in UTC? if not - no problem, let's just sort out the change in the regular expression below and merge.
There was a problem hiding this comment.
I've looked for a way but I found nothing about checking that. It seems kinda impossible unless we do an outside call to ensure if Julia's UTC is actually UTC.
I'm uploading the regex change now.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 70.25% 70.35% +0.10%
==========================================
Files 4 5 +1
Lines 279 280 +1
==========================================
+ Hits 196 197 +1
Misses 83 83
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Note:
MLFlow dashboard shows the local UTC configuration, meaning that we are not going to be able to see changes (unless we change to another machine with another timezone).