Enable remote logging #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The overall test suite keeps failing but that should be independent of my changes. I'll investigate it tomorrow. |
|
This PR is ready for review. It would be awesome if you could take a look @deyandyankov . I've added docstrings and tests for the new method. For visibility, the relevant tests pass but the overall test suite fails, because my computer blocks localhost (not sure how common/uncommon that is), but everything passes if I changed it to standard 127.0.0.1 (see tests fix branch) |
deyandyankov
approved these changes
Aug 2, 2022
|
this is now merged, I've bumped the version to 0.4.0 and have submitted the new version to be registered in General. Thank you for your contribution! |
|
Thanks for the PR! I'll review this evening.
…On Tue, 2 Aug 2022, 10:55 J S, ***@***.***> wrote:
This PR is ready for review. It would be awesome if you could take a look
@deyandyankov <https://github.com/deyandyankov> .
I've added docstrings and tests for the new method.
For visibility, the relevant tests pass but the overall test suite fails,
because my computer blocks localhost (not sure how common/uncommon that
is), but everything passes if I changed it to standard 127.0.0.1 (see tests
fix branch
<https://github.com/svilupp/MLFlowClient.jl/tree/fix-test-suite>)
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWZRGYXS4HLSTJLVQPS5T3VXDWCFANCNFSM55IUHFDA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR This is a proposal to enable remote logging (eg, Databricks or internal MLFlow servers)
Closes #21
Implementation:
headers, where user can provide authentication details for their remote server (eg, basic auth, bearer)headershas been hidden from the pretty-print (ShowCase)