steam: Include font packages for Steam Gamescope Session #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels like a lot of duplicated effort for something that could just be solved with an overlay? |
* Follow PR NixOS/nixpkgs#312268, fix CJK fonts on gamescope session.
bigsaltyfishes
force-pushed
the
fix/extrapkgs
branch
from
704132a to
e631cd3
Compare
bigsaltyfishes
changed the title
extraPackages and fontPackages.
How about just include fonts only, for extra packages can use overlays to install? At least I think we need to make base features working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream has added
extraPackagesandfontPackagesoptions to fix the display issues of CJK fonts in the Steam client. However, these option changes will generate a new Steam package through a function and will not affectsteamPackages.steam-fhsenv. Ourgamescope-sessionuses thesteamPackages.steam-fhsenvpackage instead ofprograms.steam.package. Include fonts packages fromprograms.steam.fontPackagesto solve fonts issue.Upstream PR: NixOS/nixpkgs#312268
Related issues:
extraPackagesandfontPackagesoptions not working #373