modules/decky-loader: Add enableFHSEnvironment option #248
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pongo1231
force-pushed
the
decky-loader-fhs
branch
from
d44e9c1 to
5273ebc
Compare
|
Maybe we should package Decky plugins properly instead? It shouldn't be too difficult. |
|
Would that also mean the ability to declaratively install plugins? In that case that'd certainly be a cleaner solution, though this approach might still be worthwhile for people who prefer to imperatively install / try out plugins. Unless there are some caveats (which I haven't found). |
|
I'm in camp packaged plugins myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins ship with a precompiled binary necessitating an FHS env to run them - PowerTools is one such instance where it comes with a compiled backend binary in Rust.
This adds an
enableFHSEnvironmentoption for such cases and conditionally enables a blank FHS environment in the systemd unit. I haven't encountered any issues with other plugins with this turned on.