-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prop for App ID #30
base: master
Are you sure you want to change the base?
Conversation
Thank you for this pull request!!!!! Setting the App ID is so important if you want to use drive.file scope. And drive.file scope is the BEST most minimal scope! After many hours of frustration this branch saved my project. Could this pull request please be merged? I would be happy to write some documentation on this. As it stands this node package will use drive.readonly scope by default. However if you have pre-obtained a token with only drive.file scope, then it will NOT ask for drive.readonly - which is excellent! |
Relies on branched version of google-drive-file-picker Jose-cd/React-google-drive-picker#30
src/typeDefs.ts
Outdated
@@ -48,6 +48,7 @@ type ViewIdOptions = | |||
export type PickerConfiguration = { | |||
clientId: string | |||
developerKey: string | |||
AppId?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why AppId with a capital A letter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that must have been a typo. appId is already included on line 60, so I'll update the PR to remove this line.
Although the app ID isn't always required, in some cases it is needed. For example, if using the drive.file scope, the picker won't work properly without the App ID. This pull request adds the option to specify the app ID.