-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ethers
-> alloy
rpc migration
#454
base: main
Are you sure you want to change the base?
Conversation
@@ -754,15 +745,15 @@ impl VM { | |||
let gas_cost = 6 * minimum_word_size + self.memory.expansion_cost(offset, size); | |||
self.consume_gas(gas_cost); | |||
|
|||
self.stack.push(U256::from(result), operation); | |||
self.stack.push(U256::try_from(result)?, operation); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of a fallible conversion when an infallible one could be used
--> crates/vm/src/core/vm.rs:748:33
|
748 | self.stack.push(U256::try_from(result)?, operation);
| ^^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `FixedBytes<32>` to `Uint<256, 4>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
H160::default(), | ||
Address::default(), | ||
Address::default(), | ||
Address::default(), | ||
0, | ||
u128::max_value(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: usage of a legacy numeric method
--> crates/cfg/src/core/mod.rs:77:15
|
77 | u128::max_value(),
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
|
77 | u128::MAX,
| ~~~
H160::default(), | ||
Address::default(), | ||
Address::default(), | ||
Address::default(), | ||
0, | ||
u128::max_value(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: usage of a legacy numeric method
--> crates/decompile/src/core/mod.rs:84:15
|
84 | u128::max_value(),
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
|
84 | u128::MAX,
| ~~~
Motivation
Solution