feat(utils): calldatacopy argument heuristics #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankressin
changed the title
…rgument-heuristic
Jon-Becker
requested changes
Jun 26, 2024
There was a problem hiding this comment.
finally got a chance to take a look, looks pretty good overall! there is a bit more needed to the implementation i think, since decompiling seaport 0x00000000000000adc04c56bf30ac9d3c0aaf14dc gives a lot of nonsense (most functions end up having like 20 args D:)
i think calculating arg_index needs to change for both CALLDATALOAD and CALLDATACOPY with a more sophisticated mapping calculation, since CALLDATACOPY can span multiple words and this will throw the calculations off
i'll probably add a few commits trying to address this soonish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Targets #379
Solution