Master token list: allow updates to validation schema #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tmastr.seedscontract maintains a list of tokens used in the Seeds ecosystem along with metadata such as logo image, name, etc. The contract also maintains a JSON schema on-chain which is used by several applications (including Light Wallet) to validate each token's metadata when generated or utilized.This PR corrects an oversight which made the schema string immutable (we anticipate that maintenance and extension of the schema will be desirable).
This PR also includes a minor edit to the schema itself, specifying "uri" formats.
Re: JoinSEEDS/seeds_light_wallet#1919 "Master Token List Schema",
Author is aware that use of the JSON schema in Light Wallet is controversial but this PR is a needed fix for the existing implementation independent of possible future redesign/restructuring.
@n13
Note: there is no change to table structure so we should be able to redeploy on top of the old contract without resetting tables or repeating the init. I have tested
initandsetschemaon local test net.