Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch_2_gang Update driver.settings.compose.json #818

Closed
wants to merge 1 commit into from

Conversation

TzK069
Copy link

@TzK069 TzK069 commented Mar 31, 2024

@JohanBendz , can you assist?

@TzK069 TzK069 requested a review from JohanBendz as a code owner March 31, 2024 22:09
@JohanBendz
Copy link
Owner

Hi @TzK069, you want to add Indicator setting to this device? It will require code in the device.js file too.
If you are sure the device supports it I can add the code for you to test and report, OK?

@TzK069
Copy link
Author

TzK069 commented Aug 31, 2024

Hey @JohanBendz , so happy to hear from you.

Yeah you can code it and i'll check it, the one gang already has this seeting activated, just need to the 2 gang version.

10x

@JohanBendz
Copy link
Owner

Hi again @TzK069, OK.. so you mean the "wall switch 1 gang" and "wall switch 2 gang".
In this PR you mention "switch 2 gang", this is an other device. ;)

So.. I'll add code to the "wall switch 2 gang" unit :)

@TzK069
Copy link
Author

TzK069 commented Sep 1, 2024

Ok, probably i wasan't clear.

I have one gang and two gang switches, from Moess... the 1 gang switch is working with the "indicator mode" LED on whwn gang is off and the other way, now I'm interested to do the same thing but for the 2gang thing

@JohanBendz
Copy link
Owner

OK Gotcha.
Just to check.. is there one light indicator for the device or is there one light indicator per button?

@JohanBendz JohanBendz added the enhancement New feature or request label Sep 6, 2024
@TzK069
Copy link
Author

TzK069 commented Sep 7, 2024

one light indicator per button

@TzK069
Copy link
Author

TzK069 commented Sep 14, 2024

@JohanBendz any updates? let me know when I can test it so I can return with a feedback.

@JohanBendz
Copy link
Owner

JohanBendz commented Sep 16, 2024

@TzK069
Upcoming update to the test version will have this implemented for all four models.

Please test and report back :)

@TzK069
Copy link
Author

TzK069 commented Sep 19, 2024

Hey @JohanBendz , saw that You updated the drivers, but for the wall_switch_2_gang, the model that I'm using is in the "switch_2_gang"

Model = _TZ3000_18ejxno0

Type = TS0012

It will not work, only if you add the model and type to the code.

@JohanBendz
Copy link
Owner

@TzK069, OK. So I should move _TZ3000_18ejxno0 from switch_2_gang to wall_switch_2_gang?

@TzK069
Copy link
Author

TzK069 commented Sep 20, 2024

Yeah, if the wall_switch_2_gang is the latest one that you update, from the 4 devices that you recently updated, then yes, you need to move from switch_2_gang -> wall_switch_2_gang

@TzK069
Copy link
Author

TzK069 commented Sep 20, 2024

and also
model = _TZ3000_hhiodade
product id = TS0011

to be added as model to the wall_switch_1_gang

@JohanBendz
Copy link
Owner

@TzK069 OK, new version out now with this change and _TZ3000_hhiodade is added. Let me know if this works.

@TzK069
Copy link
Author

TzK069 commented Sep 20, 2024

Hey JohanBendz, 90% is working.
The 10 % is the fact that I can't select the second switch what is it plugged in.
Please see the picture attached 

2
1

@JohanBendz
Copy link
Owner

@TzK069 My bad, will fix.

@JohanBendz JohanBendz closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants