Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made patch-1 more flexible #5

Draft
wants to merge 1 commit into
base: patch-1
Choose a base branch
from
Draft

Made patch-1 more flexible #5

wants to merge 1 commit into from

Conversation

Joeclinton1
Copy link
Owner

Patch-1 relies to much on the google image format always staying the same this version is much more flexible, and won't break every few months.

Patch-1 relies to much on the google image format always staying the same this version is much more flexible, and won't break every few months.
@Joeclinton1 Joeclinton1 changed the title Made patch-1 more flexibly Made patch-1 more flexible Sep 13, 2020
@lyris85
Copy link

lyris85 commented Sep 17, 2020

I tried your branch and it doesnt work on my ubuntu 20.04. Master branch works. I got stuff like this:

["https://encrypted-tbn0.gstatic.com/images?q\u003dtbn%3AANd9GcTJhZKj73y9awAVsXsadx3nLgK7vJt0yfDvVQ\u0026usqp\u003dCAU",188,268]\n,["https://cdn.the-scientist.com/assets/articleNo/66400/aImg/33464/cat-paw-l.png",840,1200]\n,null,0,"rgb(232,232,226)",null,false,{"2001":[null,null,null,9,0,21,9,null,null,null,[]\n]\n,"2003":[null,"fTMj9aL3mYlkuM","https://www.the-scientist.com/news-opinion/chinas-first-cloned-kitten--garlic-66400","China's First Cloned Kitten, Garlic | The Scientist Magazine\xc2\xae",null,null,null,null,null,false,null,null,"The Scientist Magazine",null,null,null,null,null,null,null,null,null,null,null,false,{"26":[null,2]\n}]\n,"2008":[null,"China's First Cloned Kitten, Garlic ..."]\n,"183836587":["the-scientist.com"]

Could not open URL. Please check your internet connection and/or ssl settings
If you are using proxy, make sure your proxy settings is configured correctly

@Joeclinton1 Joeclinton1 marked this pull request as draft September 17, 2020 14:34
@Joeclinton1
Copy link
Owner Author

@lyris85 Hi, sorry I just submitted the pull request to keep things organised but this is actually unfinished. The idea behind this is that it finds the url's one by one by using a regex to find strings which include the basic stuff required for something to be a url. This is so much more flexible, and can't break.

Once I finish it, i'll ask some people to test it and if it's better than the original, i'll merge it to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants