Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set git attribute default eol lf #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set git attribute default eol lf #177

wants to merge 1 commit into from

Conversation

quyenvsp
Copy link

@quyenvsp quyenvsp commented Jul 1, 2024

Local.kt:133 split by \n\n.
App build on Windows will crash because when clone repository git converted app/src/main/assets/scripts.js to CRLF (\r\n) if core.autocrlf==true|input
-> Local.kt:146 out of index range

JingMatrix
JingMatrix reviewed Jul 1, 2024
View reviewed changes
Copy link
Owner

@JingMatrix JingMatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid further possible conflicts with editors configurations on Windows, I think it is better to replace '*' by exact file names.
Moreover, it also indicates future contributors how ChromeXt deals with JavaScript assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingMatrix JingMatrix JingMatrix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quyenvsp @JingMatrix