null checks for #3364 and fix some bugs #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
commented
Jun 28, 2024
| @@ -291,7 +291,10 @@ internal bool CanTransactionFitInPool(Transaction tx) | |||
| { | |||
| if (Count < Capacity) return true; | |||
|
|
|||
| return GetLowestFeeTransaction(out _, out _).CompareTo(tx) <= 0; | |||
| var item = GetLowestFeeTransaction(out _, out _); | |||
| if (item == null) return false; | |||
shargon
commented
Jun 28, 2024
| @@ -400,7 +403,8 @@ private List<Transaction> RemoveOverCapacity() | |||
| List<Transaction> removedTransactions = new(); | |||
| do | |||
| { | |||
| PoolItem minItem = GetLowestFeeTransaction(out var unsortedPool, out var sortedPool); | |||
| var minItem = GetLowestFeeTransaction(out var unsortedPool, out var sortedPool); | |||
| if (minItem == null || sortedPool == null) break; | |||
There was a problem hiding this comment.
This can fail if it's null, because lime 259 and 262
shargon
changed the title
16 tasks
shargon
changed the title
|
this should be your pr on master, please do it on master directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Jim8y I removed the new warnings created by neo-project#3364 , but I found a bug, sortedPool in line 407 can be null because line 259