🐛 Fix annotation path incorrectness when --project-dir is specified #410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
When
--project-dir
is specified, the output annotation path should start with the project dir path.Related Issue
https://youtrack.jetbrains.com/issue/QD-5189/
Motivation and Context
When we specifies the
--project-dir
argument, the output annotation's path is incorrect, then the annotation is not working expectedly.For example when we have a mono repo project, which is not a Gradle multi project but just has multiple directories where some are Gradle project and others are not.
In this situation, we want to use not
--source-directory
but--project-dir
.When
--project-dir
is specified, the paths written in the output sarif file is incorrect.If the path is incorrect, qodana-action never comments at the pull request change location.
How Has This Been Tested
I tested in my private project. (Sorry it is not public)
Types of changes
Checklist