PRJ-285 JCEF support #111

ARTI1208 · 2022-02-09T17:15:35Z

Client changes: JetBrains/projector-client#130

SerVB · 2022-03-22T17:17:13Z

settings.gradle.kts

+      substitute(module("$projectorClientGroup:projector-common")).using(project(":projector-common"))
+      substitute(module("$projectorClientGroup:projector-ij-common")).using(project(":projector-ij-common"))
+      substitute(module("$projectorClientGroup:projector-server-core")).using(project(":projector-server-core"))
+      substitute(module("$projectorClientGroup:projector-util-loading")).using(project(":projector-util-loading"))
+      substitute(module("$projectorClientGroup:projector-util-logging")).using(project(":projector-util-logging"))


Why changing with to using?

SerVB · 2022-03-28T16:13:55Z

...ector-server/src/main/resources/META-INF/services/org.jetbrains.projector.common.EventSender

+# Please contact JetBrains, Na Hrebenech II 1718/10, Prague, 14000, Czech Republic
+# if you need additional information or have any questions.
+#
+org.jetbrains.projector.server.CommonQueueEventSender


Why do we need to declare such a file and inject event sender via it? Could we use some easier way of injection, like we do in other places?

zhipengzuo · 2022-04-25T06:41:47Z

build jcef branch is ok , but if run ide the ide will crash and can't click anything
error is

[ERROR] :: ProjectorServer :: Unhandled in daemon thread has happened :: java.lang.ClassCastException: class org.jetbrains.projector.server.core.websocket.HttpWsServer$Companion$HTTP_CONNECTION_ATTACHMENT$1 cannot be cast to class org.jetbrains.projector.server.core.ClientWrapper (org.jetbrains.projector.server.core.websocket.HttpWsServer$Companion$HTTP_CONNECTION_ATTACHMENT$1 and org.jetbrains.projector.server.core.ClientWrapper are in unnamed module of loader 'app')
at org.jetbrains.projector.server.core.websocket.HttpWsServer.forEachOpenedConnection(HttpWsServer.kt:292)
at org.jetbrains.projector.server.ProjectorServer.sendPictures(ProjectorServer.kt:701)
at org.jetbrains.projector.server.ProjectorServer.access$sendPictures(ProjectorServer.kt:90)
at org.jetbrains.projector.server.ProjectorServer$createUpdateThread$1.invoke(ProjectorServer.kt:237)
at org.jetbrains.projector.server.ProjectorServer$createUpdateThread$1.invoke(ProjectorServer.kt:231)
at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30)

[INFO] :: WsTransportBuilder :: 172.17.0.1 connected.
[WebSocketWorker-19] ERROR org.java_websocket.drafts.Draft_6455 - Runtime exception during onWebsocketMessage
java.lang.NullPointerException
at com.intellij.openapi.application.ApplicationInfo.getInstance(ApplicationInfo.java:17)
at org.jetbrains.projector.common.intellij.CompatibilityKt.buildAtLeast(Compatibility.kt:32)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.isCefAvailable(CefHelpers.kt:64)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.updateCefBrowsersSafely(CefHelpers.kt:68)
at org.jetbrains.projector.server.ProjectorServer$clientEventHandler$1.handleMessage(ProjectorServer.kt:197)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:47)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:46)
at org.jetbrains.projector.server.core.websocket.HttpWsServerBuilder$build$wsServer$1.onWsMessage(HttpWsServerBuilder.kt:43)
at org.jetbrains.projector.server.core.websocket.HttpWsServer$webSocketServer$1.onMessage(HttpWsServer.kt:252)
at org.java_websocket.server.WebSocketServer.onWebsocketMessage(WebSocketServer.java:703)
at org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:963)
at org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:887)
at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401)
at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.doDecode(WebSocketServer.java:1096)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.run(WebSocketServer.java:1077)
[ERROR] :: WsTransportBuilder :: onError :: java.lang.NullPointerException
at com.intellij.openapi.application.ApplicationInfo.getInstance(ApplicationInfo.java:17)
at org.jetbrains.projector.common.intellij.CompatibilityKt.buildAtLeast(Compatibility.kt:32)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.isCefAvailable(CefHelpers.kt:64)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.updateCefBrowsersSafely(CefHelpers.kt:68)
at org.jetbrains.projector.server.ProjectorServer$clientEventHandler$1.handleMessage(ProjectorServer.kt:197)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:47)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:46)
at org.jetbrains.projector.server.core.websocket.HttpWsServerBuilder$build$wsServer$1.onWsMessage(HttpWsServerBuilder.kt:43)
at org.jetbrains.projector.server.core.websocket.HttpWsServer$webSocketServer$1.onMessage(HttpWsServer.kt:252)
at org.java_websocket.server.WebSocketServer.onWebsocketMessage(WebSocketServer.java:703)
at org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:963)
at org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:887)
at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401)
at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.doDecode(WebSocketServer.java:1096)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.run(WebSocketServer.java:1077)

ERROR: onError
java.lang.NullPointerException
at com.intellij.openapi.application.ApplicationInfo.getInstance(ApplicationInfo.java:17)
at org.jetbrains.projector.common.intellij.CompatibilityKt.buildAtLeast(Compatibility.kt:32)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.isCefAvailable(CefHelpers.kt:64)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.updateCefBrowsersSafely(CefHelpers.kt:68)
at org.jetbrains.projector.server.ProjectorServer$clientEventHandler$1.handleMessage(ProjectorServer.kt:197)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:47)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:46)
at org.jetbrains.projector.server.core.websocket.HttpWsServerBuilder$build$wsServer$1.onWsMessage(HttpWsServerBuilder.kt:43)
at org.jetbrains.projector.server.core.websocket.HttpWsServer$webSocketServer$1.onMessage(HttpWsServer.kt:252)
at org.java_websocket.server.WebSocketServer.onWebsocketMessage(WebSocketServer.java:703)
at org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:963)
at org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:887)
at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401)
at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.doDecode(WebSocketServer.java:1096)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.run(WebSocketServer.java:1077)
[WebSocketWorker-19] ERROR org.java_websocket.server.WebSocketServer - Uncaught exception in thread WebSocketWorker-19: {}
java.lang.AssertionError: onError
at com.intellij.openapi.diagnostic.DefaultLogger.error(DefaultLogger.java:57)
at com.intellij.openapi.diagnostic.Logger.error(Logger.java:183)
at org.jetbrains.projector.server.core.ij.log.IjJvmLogger.error(IjJvmLogger.kt:36)
at org.jetbrains.projector.server.core.ij.log.DelegatingJvmLogger$error$1$1.invoke(DelegatingJvmLogger.kt:76)
at org.jetbrains.projector.server.core.ij.log.DelegatingJvmLogger$error$1$1.invoke(DelegatingJvmLogger.kt:76)
at org.jetbrains.projector.server.core.ij.log.DelegatingJvmLogger$Companion.log(DelegatingJvmLogger.kt:119)
at org.jetbrains.projector.server.core.ij.log.DelegatingJvmLogger$Companion.access$log(DelegatingJvmLogger.kt:105)
at org.jetbrains.projector.server.core.ij.log.DelegatingJvmLogger.error(DelegatingJvmLogger.kt:73)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$5.invoke(WsTransportBuilder.kt:75)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$5.invoke(WsTransportBuilder.kt:74)
at org.jetbrains.projector.server.core.websocket.HttpWsServerBuilder$build$wsServer$1.onError(HttpWsServerBuilder.kt:40)
at org.jetbrains.projector.server.core.websocket.HttpWsServer$webSocketServer$1.onError(HttpWsServer.kt:260)
at org.java_websocket.server.WebSocketServer.onWebsocketError(WebSocketServer.java:784)
at org.java_websocket.drafts.Draft_6455.logRuntimeException(Draft_6455.java:950)
at org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:965)
at org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:887)
at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401)
at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.doDecode(WebSocketServer.java:1096)
at org.java_websocket.server.WebSocketServer$WebSocketWorker.run(WebSocketServer.java:1077)
Caused by: java.lang.NullPointerException
at com.intellij.openapi.application.ApplicationInfo.getInstance(ApplicationInfo.java:17)
at org.jetbrains.projector.common.intellij.CompatibilityKt.buildAtLeast(Compatibility.kt:32)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.isCefAvailable(CefHelpers.kt:64)
at org.jetbrains.projector.ij.jcef.CefHelpersKt.updateCefBrowsersSafely(CefHelpers.kt:68)
at org.jetbrains.projector.server.ProjectorServer$clientEventHandler$1.handleMessage(ProjectorServer.kt:197)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:47)
at org.jetbrains.projector.server.core.websocket.WsTransportBuilder$attachDefaultServerEventHandlers$2.invoke(WsTransportBuilder.kt:46)
at org.jetbrains.projector.server.core.websocket.HttpWsServerBuilder$build$wsServer$1.onWsMessage(HttpWsServerBuilder.kt:43)
at org.jetbrains.projector.server.core.websocket.HttpWsServer$webSocketServer$1.onMessage(HttpWsServer.kt:252)
at org.java_websocket.server.WebSocketServer.onWebsocketMessage(WebSocketServer.java:703)
at org.java_websocket.drafts.Draft_6455.processFrameText(Draft_6455.java:963)
... 5 more

ARTI1208 mentioned this pull request Feb 9, 2022

PRJ-285 JCEF support JetBrains/projector-client#130

Open

ARTI1208 force-pushed the jcef branch 3 times, most recently from 787b0fd to 4b46ad4 Compare February 15, 2022 17:24

ARTI1208 marked this pull request as ready for review February 16, 2022 06:28

ARTI1208 requested a review from SerVB February 16, 2022 06:29

ARTI1208 marked this pull request as draft March 2, 2022 12:09

SerVB removed their request for review March 4, 2022 10:32

ARTI1208 added 3 commits March 22, 2022 16:49

Use intellij artifacts with sources

6405b64

Allow sending server events from client repo

bbe216f

Move build version testing function from server to client repo

3a09f3f

ARTI1208 force-pushed the jcef branch from 87b42d9 to 69b1971 Compare March 22, 2022 14:01

ARTI1208 added 4 commits March 22, 2022 18:02

PRJ-285 Add jcef support

426403e

Simplify building with different Intellij Platform dependencies versions

6a56383

Use different path selectors for different products

6ecad70

Fix CEF-related errors on platform version below 202

287d58e

ARTI1208 force-pushed the jcef branch from 69b1971 to 287d58e Compare March 22, 2022 15:10

ARTI1208 marked this pull request as ready for review March 22, 2022 15:31

ARTI1208 requested a review from SerVB March 22, 2022 15:31

SerVB reviewed Mar 28, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PRJ-285 JCEF support #111

PRJ-285 JCEF support #111

ARTI1208 commented Feb 9, 2022

SerVB Mar 22, 2022

SerVB Mar 28, 2022

zhipengzuo commented Apr 25, 2022 •

edited

Loading

PRJ-285 JCEF support #111

Are you sure you want to change the base?

PRJ-285 JCEF support #111

Conversation

ARTI1208 commented Feb 9, 2022

SerVB Mar 22, 2022

Choose a reason for hiding this comment

SerVB Mar 28, 2022

Choose a reason for hiding this comment

zhipengzuo commented Apr 25, 2022 • edited Loading

zhipengzuo commented Apr 25, 2022 •

edited

Loading